Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installations are incomplete #2169

Closed
skade opened this issue Nov 23, 2019 · 3 comments
Closed

Windows installations are incomplete #2169

skade opened this issue Nov 23, 2019 · 3 comments
Labels

Comments

@skade
Copy link
Contributor

skade commented Nov 23, 2019

Similar to #2151.

https://doc.rust-lang.org/book/ch01-01-installation.html#installing-rustup-on-windows documents:

On Windows, go to https://www.rust-lang.org/tools/install and follow the instructions for installing Rust. At some point in the installation, you’ll receive a message explaining that you’ll also need the C++ build tools for Visual Studio 2013 or later. The easiest way to acquire the build tools is to install Build Tools for Visual Studio 2019. The tools are in the Other Tools and Frameworks section.

This is correct, but not the full story: Just installing the build tools does not install link.exe and further down expose people to the "linker not found" issue. The recommended way is to actively check the box for "C++ tools". I'm not sure if this is the best way to get link.exe, as it installs 1GB of C++ frameworks along with it.

@steveklabnik
Copy link
Member

Hmm, are you sure? Has this changed or something recently?

@carols10cents
Copy link
Member

I feel like this has changed... so maybe these instructions shouldn't be in the book, but should be in rustup's documentation/error messages?

@steveklabnik
Copy link
Member

I set up a new computer today, the only thing you need to check is the "C++ build tools". check that box, and you get all this
image

that's what's described in the paragraph, and it works, so I'm gonna close this. @skade if you have some objection please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants