Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to configure whether components are installed #298

Closed
alexcrichton opened this issue Apr 12, 2016 · 7 comments
Closed

Add the ability to configure whether components are installed #298

alexcrichton opened this issue Apr 12, 2016 · 7 comments

Comments

@alexcrichton
Copy link
Member

Two use cases:

  • It'd be nice to have the ability to either opt-out of rust-docs installation or opt-in to tracking it. I don't have much of a preference either way, but I personally at least don't use the component much so it'd be nice to download/copy less.
  • For MinGW toolchains I have MSYS installed and get weird errors sometimes when the rust-mingw component is installed because C code is sometimes compiled with my MSYS toolchain and then linked with rust-mingw's toolchain (causing errors).
@alexcrichton alexcrichton changed the title Add the ability to configure whether components installed Add the ability to configure whether components are installed Apr 12, 2016
@brson
Copy link
Contributor

brson commented Apr 13, 2016

For rust-docs at least, we're just going to blanket convert it to an optional component, so it won't be installed by default.

Maybe rust-mingw should also be converted to an optional component until we figure out something better to do with it.

@brson
Copy link
Contributor

brson commented Apr 13, 2016

Adding an ability to optionally install required components seems wrong.

@brson
Copy link
Contributor

brson commented Apr 13, 2016

This issue can be for a general rustup component subcommand, which we'll need before rust-docs can become optional.

@alexcrichton
Copy link
Member Author

I'm fine leaving rust-mingw installed-by-default for now, I was just thinking that there's some way to opt out of installing it (which is persisted)

@brson
Copy link
Contributor

brson commented Apr 13, 2016

Maybe this speaks to a need for a new type of component, one that is not required but is installed by default. Though i'm still more inclined to relegate rust-mingw to the ndk layer.

@brson
Copy link
Contributor

brson commented Apr 13, 2016

(Or maybe we just don't have to be so strict about what "required" means and just allow people to mix and match components in ways that break).

@Diggsey
Copy link
Contributor

Diggsey commented May 4, 2017

Superceded by #905

@Diggsey Diggsey closed this as completed May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants