From 352587af44dfbe76fbb8cae6bd2f75ff4b292f16 Mon Sep 17 00:00:00 2001
From: Martin Nordholts <martin.nordholts@codetale.se>
Date: Wed, 20 Mar 2024 19:24:18 +0100
Subject: [PATCH 1/2] compiletest: mir_dump_dir.as_path() -> &mir_dump_dir
---
src/tools/compiletest/src/runtest.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tools/compiletest/src/runtest.rs b/src/tools/compiletest/src/runtest.rs
index 63e52df8c040e..1a2d8495dbb0e 100644
--- a/src/tools/compiletest/src/runtest.rs
+++ b/src/tools/compiletest/src/runtest.rs
@@ -2470,7 +2470,7 @@ impl<'test> TestCx<'test> {
let mir_dump_dir = self.get_mir_dump_dir();
let _ = fs::remove_dir_all(&mir_dump_dir);
- create_dir_all(mir_dump_dir.as_path()).unwrap();
+ create_dir_all(&mir_dump_dir).unwrap();
let mut dir_opt = "-Zdump-mir-dir=".to_string();
dir_opt.push_str(mir_dump_dir.to_str().unwrap());
debug!("dir_opt: {:?}", dir_opt);
From c3cc6c199012094ab3017c07a67e9b37469ebf91 Mon Sep 17 00:00:00 2001
From: Martin Nordholts <martin.nordholts@codetale.se>
Date: Wed, 20 Mar 2024 19:29:13 +0100
Subject: [PATCH 2/2] compiletest: Introduce remove_and_create_dir_all() helper
The code
let _ = fs::remove_dir_all(&dir);
create_dir_all(&dir).unwrap();
is duplicated in 7 places. Let's introduce a helper.
---
src/tools/compiletest/src/runtest.rs | 27 ++++++++++++---------------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/src/tools/compiletest/src/runtest.rs b/src/tools/compiletest/src/runtest.rs
index 1a2d8495dbb0e..85f3aa006f205 100644
--- a/src/tools/compiletest/src/runtest.rs
+++ b/src/tools/compiletest/src/runtest.rs
@@ -198,6 +198,11 @@ pub fn compute_stamp_hash(config: &Config) -> String {
format!("{:x}", hash.finish())
}
+fn remove_and_create_dir_all(path: &Path) {
+ let _ = fs::remove_dir_all(path);
+ fs::create_dir_all(path).unwrap();
+}
+
#[derive(Copy, Clone)]
struct TestCx<'test> {
config: &'test Config,
@@ -998,8 +1003,7 @@ impl<'test> TestCx<'test> {
let mut rustc = Command::new(&self.config.rustc_path);
let out_dir = self.output_base_name().with_extension("pretty-out");
- let _ = fs::remove_dir_all(&out_dir);
- create_dir_all(&out_dir).unwrap();
+ remove_and_create_dir_all(&out_dir);
let target = if self.props.force_host { &*self.config.host } else { &*self.config.target };
@@ -2094,14 +2098,12 @@ impl<'test> TestCx<'test> {
let aux_dir = self.aux_output_dir_name();
if !self.props.aux_builds.is_empty() {
- let _ = fs::remove_dir_all(&aux_dir);
- create_dir_all(&aux_dir).unwrap();
+ remove_and_create_dir_all(&aux_dir);
}
if !self.props.aux_bins.is_empty() {
let aux_bin_dir = self.aux_bin_output_dir_name();
- let _ = fs::remove_dir_all(&aux_bin_dir);
- create_dir_all(&aux_bin_dir).unwrap();
+ remove_and_create_dir_all(&aux_bin_dir);
}
aux_dir
@@ -2469,8 +2471,7 @@ impl<'test> TestCx<'test> {
}
let mir_dump_dir = self.get_mir_dump_dir();
- let _ = fs::remove_dir_all(&mir_dump_dir);
- create_dir_all(&mir_dump_dir).unwrap();
+ remove_and_create_dir_all(&mir_dump_dir);
let mut dir_opt = "-Zdump-mir-dir=".to_string();
dir_opt.push_str(mir_dump_dir.to_str().unwrap());
debug!("dir_opt: {:?}", dir_opt);
@@ -2951,8 +2952,7 @@ impl<'test> TestCx<'test> {
assert!(self.revision.is_none(), "revisions not relevant here");
let out_dir = self.output_base_dir();
- let _ = fs::remove_dir_all(&out_dir);
- create_dir_all(&out_dir).unwrap();
+ remove_and_create_dir_all(&out_dir);
let proc_res = self.document(&out_dir);
if !proc_res.status.success() {
@@ -2986,9 +2986,7 @@ impl<'test> TestCx<'test> {
let suffix =
self.safe_revision().map_or("nightly".into(), |path| path.to_owned() + "-nightly");
let compare_dir = output_base_dir(self.config, self.testpaths, Some(&suffix));
- // Don't give an error if the directory didn't already exist
- let _ = fs::remove_dir_all(&compare_dir);
- create_dir_all(&compare_dir).unwrap();
+ remove_and_create_dir_all(&compare_dir);
// We need to create a new struct for the lifetimes on `config` to work.
let new_rustdoc = TestCx {
@@ -3137,8 +3135,7 @@ impl<'test> TestCx<'test> {
assert!(self.revision.is_none(), "revisions not relevant here");
let out_dir = self.output_base_dir();
- let _ = fs::remove_dir_all(&out_dir);
- create_dir_all(&out_dir).unwrap();
+ remove_and_create_dir_all(&out_dir);
let proc_res = self.document(&out_dir);
if !proc_res.status.success() {