Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to bitcoind crate for integration testing #361

Closed
sanket1729 opened this issue Apr 20, 2022 · 3 comments · Fixed by #420
Closed

Move to bitcoind crate for integration testing #361

sanket1729 opened this issue Apr 20, 2022 · 3 comments · Fixed by #420

Comments

@sanket1729
Copy link
Member

bitcoind crate is a more maintained wrapper around bitcoin-core-rpc. We should shift our integration testing framework to use it. It fits it nicely with cargo tests and allows locally running integration tests easily.

I think we should mark that as optional in the CI build, as it will delay our release cycle adding yet another dependency that needs to be updated every-time there is a rust-bitcoin release.

@apoelstra
Copy link
Member

To clarify: when rust-bitcoin updates, both this crate and bitcoind will need to update their rust-bitcoin dependency, so your proposal is to make the dep optional (and disable/ignore it) during the periods when we're waiting for bitcoind to catch up?

@sanket1729
Copy link
Member Author

Make this check optional in CI build.

For every release in the past few releases, we have been stuck for 1-2 weeks after rust-bitcoin to have a rust-miniscript release out because of this. Ideally, we want this in the CI check. I am about to suggest adding more maintainers to rust-bitcoincore-rpc. Basically only steven maintains this now, and he is busy with other multiple projects.

It is a fairly low amount of work to keep updating this every rust-bitcoin release(took me 10 mins for this PR) rust-bitcoin/rust-bitcoincore-rpc#217.

If we also integrate this with the rust-bitcoin cycle and add rust-bitcoin maintainers there, it can help speed up things for us here. I will ask @stevenroose to see if he is okay with that. We don't need the code to be high quality in rust-bitcoincore-rpc, so maintenance is just chasing obvious compiler errors every rust-bitcoin release and making a prompt release.

@sanket1729
Copy link
Member Author

I realized that there are two related things in this issue. Created a separate issue for it.

  1. Move to bitcoind. This issue
  2. Fix CI failure on merge commit, blocked on rust-bitcoincore-rpc release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants