-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to bitcoind
crate for integration testing
#361
Comments
To clarify: when rust-bitcoin updates, both this crate and |
Make this check optional in CI build. For every release in the past few releases, we have been stuck for 1-2 weeks after rust-bitcoin to have a rust-miniscript release out because of this. Ideally, we want this in the CI check. I am about to suggest adding more maintainers to It is a fairly low amount of work to keep updating this every rust-bitcoin release(took me 10 mins for this PR) rust-bitcoin/rust-bitcoincore-rpc#217. If we also integrate this with the rust-bitcoin cycle and add rust-bitcoin maintainers there, it can help speed up things for us here. I will ask @stevenroose to see if he is okay with that. We don't need the code to be high quality in |
I realized that there are two related things in this issue. Created a separate issue for it.
|
bitcoind
crate is a more maintained wrapper around bitcoin-core-rpc. We should shift our integration testing framework to use it. It fits it nicely with cargo tests and allows locally running integration tests easily.I think we should mark that as optional in the CI build, as it will delay our release cycle adding yet another dependency that needs to be updated every-time there is a rust-bitcoin release.
The text was updated successfully, but these errors were encountered: