Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff Markdown Should Have Colour Highlighting for Indented Created/Removed items #1395

Open
murrelljenna opened this issue Feb 10, 2021 · 0 comments
Labels
feature New functionality/enhancement Stale

Comments

@murrelljenna
Copy link

Current diff format doesn't work well with most markdown highlighters (including GitHub's). Indented +s and -s do not receive colour highlighting.

Using Atlantis v0.16.0.

Actual results

Current v0.16.0.
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
+ create
~ update in-place

Terraform will perform the following actions:

  # google_compute_instance.computer will be updated in-place
~ resource "google_compute_instance" "computer" {
        allow_stopping_for_update = true
        can_ip_forward            = false
        cpu_platform              = "Intel Skylake"
        current_status            = "RUNNING"
        deletion_protection       = false
        enable_display            = false
        guest_accelerator         = []
        id                        = "projects/skynet/zones/northamerica-northeast1-a/instances/computer"
        instance_id               = "..."
        label_fingerprint         = "..."
        labels                    = {}
        machine_type              = "n1-standard-1"
      ~ metadata                  = {
            "block-project-ssh-keys" = "true"
          - "ssh-keys"               = "ubuntu:ssh-rsa AAAAB..." -> null
        }
        

Expected results

Preferred with better colouring
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
+ create
- remove
~ update in-place

Terraform will perform the following actions:

  # google_compute_instance.computer will be updated in-place
~ resource "google_compute_instance" "computer" {
        allow_stopping_for_update = true
        can_ip_forward            = false
        cpu_platform              = "Intel Skylake"
        current_status            = "RUNNING"
        deletion_protection       = false
        enable_display            = false
        guest_accelerator         = []
        id                        = "projects/skynet/zones/northamerica-northeast1-a/instances/computer"
        instance_id               = "..."
        label_fingerprint         = "..."
        labels                    = {}
        machine_type              = "n1-standard-1"
      ~ metadata                  = {
            "block-project-ssh-keys" = "true"
-           "ssh-keys"               = "ubuntu:ssh-rsa AAAAB..." -> null
        }
        
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement Stale
Projects
None yet
Development

No branches or pull requests

2 participants