diff --git a/.github/workflows/on-pr.yaml b/.github/workflows/on-pr.yaml index fbf9788..1d5dc64 100644 --- a/.github/workflows/on-pr.yaml +++ b/.github/workflows/on-pr.yaml @@ -17,7 +17,7 @@ jobs: uses: devcontainers/ci@v0.3 with: runCmd: | - make test + make test && \ PACKAGE_VERSION=${{ env.PACKAGE_VERSION }} make build - name: Set package file names diff --git a/Makefile b/Makefile index 5b68e69..bfc5f92 100644 --- a/Makefile +++ b/Makefile @@ -1,16 +1,16 @@ .PHONY: build test install build: - make -C cpp clean - make -C py clean - make -C cpp build + make -C cpp clean && \ + make -C py clean && \ + make -C cpp build && \ make -C py build install: build make -C py install test: install - make -C cpp test - make -C py test + make -C cpp test && \ + make -C py test && \ make -C tests all diff --git a/cpp/Makefile b/cpp/Makefile index 661df90..409a15d 100644 --- a/cpp/Makefile +++ b/cpp/Makefile @@ -1,7 +1,7 @@ .PHONY: build build_mock test build: - bazel build streamer:libstreamer.so + bazel build streamer:libstreamer.so && \ bazel build --define USE_SYSTEM_LIBS=${USE_SYSTEM_LIBS} s3:libstreamers3.so build_mock: diff --git a/py/runai_model_streamer/runai_model_streamer/file_streamer/tests/test_file_streamer.py b/py/runai_model_streamer/runai_model_streamer/file_streamer/tests/test_file_streamer.py index e6f2b37..8f622a8 100644 --- a/py/runai_model_streamer/runai_model_streamer/file_streamer/tests/test_file_streamer.py +++ b/py/runai_model_streamer/runai_model_streamer/file_streamer/tests/test_file_streamer.py @@ -30,7 +30,7 @@ def test_runai_library(self): for id, dst, offset in fs.get_chunks(): self.assertEqual(offset, id_to_results[id]["expected_offset"]) self.assertEqual( - dst[offset : offset + request_sizes[id]].decode("utf-8"), + dst[offset : offset + request_sizes[id]].tobytes().decode("utf-8"), id_to_results[id]["expected_text"], ) @@ -63,7 +63,7 @@ def test_min_memory_cap(self, mock_get_memory_mode): for id, dst, offset in fs.get_chunks(): self.assertEqual(offset, id_to_results[id]["expected_offset"]) self.assertEqual( - dst[offset : offset + request_sizes[id]].decode("utf-8"), + dst[offset : offset + request_sizes[id]].tobytes().decode("utf-8"), id_to_results[id]["expected_text"], ) @@ -95,7 +95,7 @@ def test_limited_memory_cap(self, mock_get_memory_mode, mock_getenv): for id, dst, offset in fs.get_chunks(): self.assertEqual(offset, id_to_results[id]["expected_offset"]) self.assertEqual( - dst[offset : offset + request_sizes[id]].decode("utf-8"), + dst[offset : offset + request_sizes[id]].tobytes().decode("utf-8"), id_to_results[id]["expected_text"], ) diff --git a/tests/fuzzing/test_file_streamer.py b/tests/fuzzing/test_file_streamer.py index ddc7633..09602a4 100644 --- a/tests/fuzzing/test_file_streamer.py +++ b/tests/fuzzing/test_file_streamer.py @@ -69,7 +69,7 @@ def test_file_streamer(self): for id, dst, offset in fs.get_chunks(): self.assertEqual(offset, expected_id_to_results[id]["expected_offset"]) self.assertEqual( - dst[offset : offset + request_sizes[id]], + dst[offset : offset + request_sizes[id]].tobytes(), expected_id_to_results[id]["expected_content"], )