Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigDecimal param conversion broke after upgrading from 1.1.0 to 1.3.3 #2074

Closed
GProst opened this issue Jun 23, 2020 · 3 comments
Closed

BigDecimal param conversion broke after upgrading from 1.1.0 to 1.3.3 #2074

GProst opened this issue Jun 23, 2020 · 3 comments
Labels

Comments

@GProst
Copy link

GProst commented Jun 23, 2020

Previously (in 1.1.0) if an empty string was passed it was converted to nil
Now in 1.3.3 it keeps param as an empty string which isn't expected.

I'd expect it to either work as in 1.1.0 or at least return 400 status

@dblock
Copy link
Member

dblock commented Jun 24, 2020

Can you please try it against HEAD, I suspect this is fixed in #2067. If not, try writing a spec?

@dblock dblock added the bug? label Jun 24, 2020
@GProst
Copy link
Author

GProst commented Jun 24, 2020

@dblock yeah, seems like it's fixed in master
When do you plan to release 1.4.0?

@dblock
Copy link
Member

dblock commented Jun 24, 2020

Add a +1 to #2030

@dblock dblock closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants