Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.3 => Nil handling #2058

Closed
ericproulx opened this issue May 25, 2020 · 3 comments
Closed

Release 1.3.3 => Nil handling #2058

ericproulx opened this issue May 25, 2020 · 3 comments

Comments

@ericproulx
Copy link
Contributor

Hello @dnesteryuk, thank you for the 1.3.3. release. Speaking of, I thought you would release a 1.4 since we made a significant change when handling nil values. I don't mind the 1.3.3 version but https://github.com/ruby-grape/grape/blob/master/UPGRADING.md shows >= 1.4 for the nils.

Thanks

@dnesteryuk
Copy link
Member

@ericproulx Oh, I missed that :( We had 1.3.3 in the changelog, so I though it should be 1.3.3 😭

@dblock Do you think we need to release 1.4.0?

@ericproulx
Copy link
Contributor Author

ericproulx commented May 25, 2020 via email

@dblock
Copy link
Member

dblock commented May 26, 2020

I don't think it will help because 1.3.3 is out and I don't think we should yank it. I've corrected the version in UPGRADING in dblock@d8b66d5.

Let's make sure we ask to bump the version in backwards incompatible PRs before merging. This was probably my bad.

@dblock dblock closed this as completed in d8b66d5 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants