Cop idea: Detection of date comparison in where scopes

[anthony-robin]

I discovered recently I could rewrite a manual scope comparing dates using Rails power directly.

For example:

Before

Event.where('at >= ?', Time.current) 
# => "SELECT \"events\".* FROM \"events\" WHERE (at >= '2023-01-22 20:14:34.878368')"

Event.where('at < ?', Time.current) 
# => "SELECT \"events\".* FROM \"events\" WHERE (at < '2023-01-22 20:14:34.878368')"

After

Event.where(at: Time.current..)
# =>  "SELECT \"events\".* FROM \"events\" WHERE \"events\".\"at\" >= '2023-01-22 20:14:34.878368'"

Event.where(at: ...Time.current)
# => "SELECT \"events\".* FROM \"events\" WHERE \"events\".\"at\" < '2023-01-22 20:14:34.878368'"

In the same way, the cop should handle:

- `<` : `…Time.current`
- `<=` : `..Time.current`
- `>=` : `Time.current..`
- `>` : `Time.current…` # seems to behave as `>=`

I haven’t seen any cop that could detect this, what do you think about adding a new rule to the gem ?

Thank you :)

Some related context from Rails repo: rails/rails#47054 (comment)

[fatkodima]

Duplicate - #689 ?

[anthony-robin]

Indeed, it seems a duplicate of #689

Thanks for the catch, will close this one 👍