-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glyphs using a single shape overlapping itself failed to be flattened #51
Comments
The bug is in fontbuild at inter/misc/pylib/fontbuild/Build.pyx Lines 307 to 310 in f7868ac
An optimization looks at a glyph's contours and if there's only a single contour—as the case with e.g. "e"—it skips the expensive union boolean operation. There's probably a cheap way to check if there's any overlap even for single-contour glyphs. |
I have a fix for this, but it increases build times by a considerable amount of time (29s -> 43s). Before pushing a fix for this, I want to investigate if I can speed up the process. |
I wasn't able to find a way to speed things up, so considering 57238c6 to fix this. |
Here's a build with the fix |
Beta release with these changes incorporated: https://github.com/rsms/inter/releases/tag/v2.5-beta |
Thank you! |
Overlaps aren't removed in glyphs using a single shape, overlapping itself (i.e. "P", "e", "6", "9", etc.).
The text was updated successfully, but these errors were encountered: