Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use browserify and watchify as peer and dev depedency #16

Conversation

oroce
Copy link
Contributor

@oroce oroce commented Mar 20, 2018

I saw the discussion in #14 so I did this pr.

To notify the users we could add the following snippet to the bin/cmd.js:

+try {
+  require.resolve('browserify');
+} catch (x) {
+  console.error('browserify is not install, run npm install browserify');
+  process.exit(1);
+}
run();

@royriojas
Copy link
Owner

Hi @oroce,

Thanks for the PR could you please add the snippet to warn users of this change?

@ruffle1986
Copy link

Just a little message correction: browserify is not installed

@oroce oroce force-pushed the chore/move-browserify-and-watchify-to-peer-dependencies branch from 06aa1dc to c523745 Compare March 22, 2018 09:21
@oroce
Copy link
Contributor Author

oroce commented Mar 22, 2018

@royriojas I just added the snippet!

@royriojas
Copy link
Owner

Thanks @oroce merging it now

@royriojas royriojas merged commit 08c825a into royriojas:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants