feat(nhsuk-frontend-react): replace form group error line prop

BREAKING CHANGE: replace disableErrorLine with withErrorLine
rowellx68 · Sep 27, 2024 · 1fa696d · 1fa696d
1 parent 87ff4ec
commit 1fa696d
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 4 deletions.
diff --git a/packages/nhsuk-frontend-react/src/components/core/form-group/FormGroup.tsx b/packages/nhsuk-frontend-react/src/components/core/form-group/FormGroup.tsx
@@ -34,7 +34,7 @@ export type BaseFormElementProps = {
   hintProps?: HintProps;
   errorProps?: ErrorMessageProps;
   formGroupProps?: ElementProps<'div'>;
-  disableErrorLine?: boolean;
+  withErrorLine?: boolean;
 };
 
 type FormGroupProps = BaseFormElementProps & {
@@ -65,7 +65,7 @@ const _FormGroup = forwardRef<HTMLInputElement, FormGroupProps>(
       render,
       formGroupProps = {},
       fieldsetProps = {},
-      disableErrorLine,
+      withErrorLine,
       error,
       label,
       hint,
@@ -160,7 +160,7 @@ const _FormGroup = forwardRef<HTMLInputElement, FormGroupProps>(
             className: clsx(
               'nhsuk-form-group',
               {
-                'nhsuk-form-group--error': !disableErrorLine && error,
+                'nhsuk-form-group--error': withErrorLine && error,
               },
               formGroupClass,
             ),
@@ -177,7 +177,7 @@ const _FormGroup = forwardRef<HTMLInputElement, FormGroupProps>(
             className: clsx(
               'nhsuk-form-group',
               {
-                'nhsuk-form-group--error': !disableErrorLine && error,
+                'nhsuk-form-group--error': withErrorLine && error,
               },
               formGroupClass,
             ),

diff --git a/packages/nhsuk-frontend-react/src/components/form-elements/checkbox/Checkbox.tsx b/packages/nhsuk-frontend-react/src/components/form-elements/checkbox/Checkbox.tsx
@@ -68,6 +68,7 @@ const Checkbox = factory<CheckboxFactory>(({ children, ...props }, ref) => {
     <CheckboxProvider value={value}>
       <FormGroup
         as="div"
+        withErrorLine
         {...props}
         ref={internalRef}
         inputType="checkboxes"

diff --git a/packages/nhsuk-frontend-react/src/components/form-elements/date-input/DateInput.tsx b/packages/nhsuk-frontend-react/src/components/form-elements/date-input/DateInput.tsx
@@ -89,6 +89,7 @@ const DateInput = factory<DateInputFactory>(
     return (
       <FormGroup
         as="div"
+        withErrorLine
         {...props}
         ref={ref}
         fieldsetProps={{ role: 'group' }}

diff --git a/packages/nhsuk-frontend-react/src/components/form-elements/input/Input.tsx b/packages/nhsuk-frontend-react/src/components/form-elements/input/Input.tsx
@@ -31,6 +31,7 @@ const Input = factory<InputFactory>(
     return (
       <FormGroup
         as="input"
+        withErrorLine
         {...props}
         ref={ref}
         inputType="input"

diff --git a/packages/nhsuk-frontend-react/src/components/form-elements/radio/Radio.tsx b/packages/nhsuk-frontend-react/src/components/form-elements/radio/Radio.tsx
@@ -64,6 +64,7 @@ const Radio = factory<RadioFactory>(({ children, inline, ...props }, ref) => {
     <RadioProvider value={value}>
       <FormGroup
         as="div"
+        withErrorLine
         {...props}
         ref={internalRef}
         inputType="radios"

diff --git a/packages/nhsuk-frontend-react/src/components/form-elements/select/Select.tsx b/packages/nhsuk-frontend-react/src/components/form-elements/select/Select.tsx
@@ -22,6 +22,7 @@ const Select = factory<SelectFactory>((props, ref) => {
     <FormGroup
       as="select"
       inputType="select"
+      withErrorLine
       {...props}
       ref={ref}
       render={({ id, name, className, withError, ...rest }) => (

diff --git a/packages/nhsuk-frontend-react/src/components/form-elements/textarea/Textarea.tsx b/packages/nhsuk-frontend-react/src/components/form-elements/textarea/Textarea.tsx
@@ -91,6 +91,7 @@ const Textarea = factory<TextareaFactory>(
         <FormGroup
           as="textarea"
           inputType="textarea"
+          withErrorLine
           {...props}
           ref={internalRef}
           render={({ id, name, className, withError, ...rest }) => (