Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE 5 with newest git version #7586

Closed
Hallikas opened this issue Sep 3, 2020 · 5 comments
Closed

TinyMCE 5 with newest git version #7586

Hallikas opened this issue Sep 3, 2020 · 5 comments

Comments

@Hallikas
Copy link

Hallikas commented Sep 3, 2020

I just updated to current GIT Master version, and we found out that when replying HTML type message, original quote is cleared out. If editor is set to 'plain text' from settings, it works. Also quote works if original message is plain text.

This looks like almost as same issue as #7568, except he has 'quote headers', I have just blank canvas.

... After very extensive search, I did found out that reason for this was missing tinymce theme, silver. This theme 'silver' does not exist, but after switching it back to modern, replying works again.

After I did find out that this was my issue, I figured out that I had old version of TinyMCE, so first I tried to install new one by hand. No go, so I used ./bin/install-jsdeps.sh to verify/install all depencies.

Everything was fine, and most of my issues was fixed. Except html editor did not work as expected. I did use browser developer mode to find out that there is javascript error message, "tinymce.ui is undefined". Looks like that it has something to do with 'tinymce.ui.Factory' class. (I don't know anything about javascript, so I'm just guessing) ;)

  • Semi
@Hallikas
Copy link
Author

Hallikas commented Sep 3, 2020

image

@alecpl
Copy link
Member

alecpl commented Sep 4, 2020

Works for me. What browser? Could you remove program/js/tinymce folder and execute the install-jsdeps.sh script again?

@Hallikas
Copy link
Author

Hallikas commented Sep 4, 2020

I switched from firefox to chrome and it worked. After that I did clear cache from firefox and it seems that problem was cache.

@alecpl
Copy link
Member

alecpl commented Sep 5, 2020

I see. Looks like the browser loaded the old tinymce with new version cache buster. So, that's why after you updated tinymce it didn't refresh the cache.

@alecpl alecpl closed this as completed Sep 5, 2020
@kalyankalapala
Copy link

When can we expect the latest roundcube version with tinymce 5 (as power plugin is also included which fixes the broken HTML) ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants