Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add helper methods to show correct trace in sentry #85

Merged
merged 1 commit into from
May 3, 2020
Merged

fix: add helper methods to show correct trace in sentry #85

merged 1 commit into from
May 3, 2020

Conversation

sum2000
Copy link
Member

@sum2000 sum2000 commented May 3, 2020

closes #83

@sum2000 sum2000 requested a review from morningvera May 3, 2020 20:52
morningvera
morningvera reviewed May 3, 2020
View reviewed changes
Copy link
Member

@morningvera morningvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from that minor comment

eris.go Outdated Show resolved Hide resolved
morningvera
morningvera requested changes May 3, 2020
View reviewed changes
eris.go Outdated Show resolved Hide resolved
@sum2000 sum2000 force-pushed the fix/sentry-logging branch from 73a7c8c to 0962a81 Compare May 3, 2020 21:19
morningvera
morningvera previously approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@morningvera morningvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@sum2000 sum2000 force-pushed the fix/sentry-logging branch from 0962a81 to 02c3fb0 Compare May 3, 2020 21:30
@sum2000 sum2000 merged commit df2bfb1 into master May 3, 2020
@sum2000 sum2000 deleted the fix/sentry-logging branch May 3, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningvera morningvera morningvera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing error chain trace in Sentry
2 participants
@sum2000 @morningvera