refactor: check for global stack traces instead of forcing NewGlobal #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 89.36% 89.54% +0.18%
==========================================
Files 3 3
Lines 282 287 +5
==========================================
+ Hits 252 257 +5
Misses 19 19
Partials 11 11
Continue to review full report at Codecov.
|
sum2000
requested changes
Jan 28, 2020
morningvera
force-pushed
the
refactor/global-errors
branch
from
a8d5d1b to
5d11a36
Compare
|
Until we don't release a new version, people will still be using NewGlobal so maybe we should not updated docs and example until then? |
morningvera
force-pushed
the
refactor/global-errors
branch
from
5d11a36 to
e6330bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.