Skip to content
This repository was archived by the owner on Dec 9, 2021. It is now read-only.

OSPL_URI warning obnoxious #18

Closed
paulbovbel opened this issue Feb 6, 2019 · 2 comments
Closed

OSPL_URI warning obnoxious #18

paulbovbel opened this issue Feb 6, 2019 · 2 comments

Comments

@paulbovbel
Copy link
Contributor

paulbovbel commented Feb 6, 2019


Feature request

Feature description

The warning implemented here (https://github.com/ros2/rosidl_typesupport_opensplice/blob/master/opensplice_cmake_module/env_hook/opensplice.sh.in#L71) is a little overwhelming, it appears during every environment load (e.g. new bash shell) when using a custom OSPL_URI.

Would you take a PR to remove it? I would think if the user is setting OSPL_URI, they are doing so intentionally.

@clalancette
Copy link
Contributor

Up until recently, the install instructions were telling the user to always override OSPL_URI. The combination of that plus the warning are what allowed us to find that problem and fix the documentation for it.

Now that the install documentation is fixed, I personally think that it would be fine to remove the warning, but I'd be interested if anyone else on @ros2/team has a different opinion.

@wjwwood
Copy link
Member

wjwwood commented Feb 8, 2019

Now that the install documentation is fixed, I personally think that it would be fine to remove the warning, but I'd be interested if anyone else on @ros2/team has a different opinion.

Sounds good to me.

@tfoote tfoote added the in review Waiting for review (Kanban column) label Feb 8, 2019
@clalancette clalancette removed the in review Waiting for review (Kanban column) label Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants