Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optimization for copying arrays of simple types from python to C using buffer protocol (backport #129) #148

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 23, 2021

This is an automatic backport of pull request #129 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…C using buffer protocol (#129)

* Added optimization for copying arrays of simple types from python to C

Signed-off-by: ksuszka <[email protected]>

* Apply suggestions from code review

Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Krzysztof Suszka <[email protected]>

* Remove setting error message twice

Signed-off-by: Krzysztof Suszka <[email protected]>

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 1796dfd)
@sloretz
Copy link
Contributor

sloretz commented Nov 23, 2021

Opened to double check #146 has no extra changes, and confirmed that there are no changes. Closing

https://github.com/hexonxons/rosidl_python/compare/foxy_copying_array_optimization..ros2:mergify/bp/foxy/pr-129

@sloretz sloretz closed this Nov 23, 2021
@sloretz sloretz deleted the mergify/bp/foxy/pr-129 branch November 23, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants