Fix int32[] and uint32[] 32 bit sequence types only accepting 16 bit sequences #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this bug while reviewing #129. There is a bug with the types of
int32[]
anduint32[]
message fields where 32 bit sequences are being stored in types that only accepts 16bit values. The tests look like they're covering this case, but actually they aren't because the comparison ofarray.array()
instances is not intuitive.array.array()
comparisons don't consider typecodearray.array()
comparisons seem to check equality of the sequences they were created with, not the bytes they outputThis should be backported to Foxy and Galactic.