From 0f1d8153c56fb6522481d233100f113efcd0c6f2 Mon Sep 17 00:00:00 2001 From: ksuszka Date: Fri, 30 Apr 2021 18:40:31 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Chris Lalancette --- rosidl_generator_py/resource/_msg_support.c.em | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rosidl_generator_py/resource/_msg_support.c.em b/rosidl_generator_py/resource/_msg_support.c.em index a23e9d0b..051f2ede 100644 --- a/rosidl_generator_py/resource/_msg_support.c.em +++ b/rosidl_generator_py/resource/_msg_support.c.em @@ -253,7 +253,7 @@ nested_type = '__'.join(type_.namespaced_name()) // Optimization for converting arrays of primitives Py_buffer view; int rc = PyObject_GetBuffer(field, &view, PyBUF_SIMPLE); - if (rc) { + if (rc < 0) { PyErr_SetString(PyExc_RuntimeError, "unable to get buffer"); Py_DECREF(field); return false; @@ -267,7 +267,7 @@ nested_type = '__'.join(type_.namespaced_name()) } @primitive_msg_type_to_c(member.type.value_type) * dest = ros_message->@(member.name).data; rc = PyBuffer_ToContiguous(dest, &view, view.len, 'C'); - if (rc) { + if (rc < 0) { PyErr_SetString(PyExc_RuntimeError, "unable to copy buffer"); PyBuffer_Release(&view); Py_DECREF(field);