Apply suggestions from code review

Co-authored-by: Chris Lalancette <[email protected]>
ros2 · Apr 30, 2021 · 0f1d815 · 0f1d815
1 parent 841dfdb
commit 0f1d815
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/rosidl_generator_py/resource/_msg_support.c.em b/rosidl_generator_py/resource/_msg_support.c.em
@@ -253,7 +253,7 @@ nested_type = '__'.join(type_.namespaced_name())
       // Optimization for converting arrays of primitives
       Py_buffer view;
       int rc = PyObject_GetBuffer(field, &view, PyBUF_SIMPLE);
-      if (rc) {
+      if (rc < 0) {
         PyErr_SetString(PyExc_RuntimeError, "unable to get buffer");
         Py_DECREF(field);
         return false;
@@ -267,7 +267,7 @@ nested_type = '__'.join(type_.namespaced_name())
       }
       @primitive_msg_type_to_c(member.type.value_type) * dest = ros_message->@(member.name).data;
       rc = PyBuffer_ToContiguous(dest, &view, view.len, 'C');
-      if (rc) {
+      if (rc < 0) {
         PyErr_SetString(PyExc_RuntimeError, "unable to copy buffer");
         PyBuffer_Release(&view);
         Py_DECREF(field);