Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate C typesupport for Actions #302

Closed
sloretz opened this issue Oct 18, 2018 · 1 comment
Closed

Generate C typesupport for Actions #302

sloretz opened this issue Oct 18, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@sloretz
Copy link
Contributor

sloretz commented Oct 18, 2018

Feature request

There should be a C file importable as #include <package_name/action/actionname.h> for an action. That file should include the service and message definitions that make up an action.

Feature description

There should be one C file importable that describes the services and messages needed to use an action. These services and messages are discoverable based on the name of their types.

Implementation considerations

Services include message type supports, so actions should use a similar strategy.

Services have one top level file including a request and response typesupport for messages.

#include "@(spec.pkg_name)/srv/@(get_header_filename_from_msg_name(spec.srv_name))__request.h"
#include "@(spec.pkg_name)/srv/@(get_header_filename_from_msg_name(spec.srv_name))__response.h"

Actions should have a top level file that includes the "Send Goal " service type support, "Get result" service type support, and "Feedback" message type support. It could also include a cancel goal service and status message from rcl_interfaces

TODO what is ROSIDL_TYPESUPPORT_INTERFACE__SERVICE_SYMBOL_NAME doing, and does there need to be a matching function for actions?

#define ROSIDL_TYPESUPPORT_INTERFACE__SERVICE_SYMBOL_NAME( \

blocked by ros2/rcl_interfaces#40
connects to ros2/ros2#583

@sloretz sloretz added the enhancement New feature or request label Oct 18, 2018
@sloretz sloretz added this to the crystal milestone Oct 18, 2018
@sloretz sloretz mentioned this issue Oct 18, 2018
24 tasks
@sloretz sloretz changed the title Generate C header file(s) for Actions Generate C typesupport for Actions Oct 18, 2018
@jacobperron jacobperron mentioned this issue Nov 2, 2018
10 tasks
@sloretz
Copy link
Contributor Author

sloretz commented Nov 13, 2018

Fixed by #312 and ros2/rosidl_typesupport#36

@sloretz sloretz closed this as completed Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant