Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing quotes in doc for "Improved Dynamic Discovery" #4951

Closed
julianmueller opened this issue Jan 21, 2025 · 2 comments
Closed

Missing quotes in doc for "Improved Dynamic Discovery" #4951

julianmueller opened this issue Jan 21, 2025 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@julianmueller
Copy link

In the documentation of "Improved Dynamic Discovery" (here), the example for defining the environment variable ROS_STATIC_PEERS looks like this:

export ROS_STATIC_PEERS=192.168.0.1;remote.com

which is wrong. Bash will interpret everything after the semicolon (;) as a new command. The variable should be in quotes:

export ROS_STATIC_PEERS="192.168.0.1;remote.com"

which worked on my setup.

@kscottz kscottz added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 23, 2025
@kscottz
Copy link
Collaborator

kscottz commented Jan 23, 2025

This looks legitimate. Let me see what I can do.

@fujitatomoya
Copy link
Collaborator

closing this, rolling and jazzy has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants