Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of C++ logging implementation #2239

Closed
cadmus-to opened this issue Jan 23, 2022 · 2 comments
Closed

Add example of C++ logging implementation #2239

cadmus-to opened this issue Jan 23, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@cadmus-to
Copy link

(Referenced in #2026)

I'm not sure if this should be a separate issue, but it is within the scope of this one.

Under Logging Usage for C++ at the Concept page (https://docs.ros.org/en/rolling/Concepts/About-Logging.html), there probably should be a C++ implementation demo similar to the Python's one. Probably something like:

Yeah just thought it'd be good to put a link for that there, in a similar fashion to the Python demo.

@kurshakuz
Copy link
Collaborator

kurshakuz commented Jan 26, 2022

Having similar content present under different languages makes a lot of sense to me. However, the package you mentioned seems to serve a little bit different purpose and is not as intuitive as Python example. I have found similar implementation in C++ which implements the same example and could fit better.

Now the only thing missing is an extensive test example for rclcpp logging.

@clalancette clalancette added the help wanted Extra attention is needed label Feb 10, 2022
@clalancette
Copy link
Contributor

We've significantly redone the logging documentation since this issue was opened, and I now think that http://docs.ros.org/en/rolling/Concepts/About-Logging.html does a much better job of explaining what is available.

Based on that, I'm going to close this out. But feel free to reopen if you still think this is an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants