Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of the severity level for eProsima logging #150

Closed
deng02 opened this issue Aug 25, 2017 · 3 comments
Closed

Allow configuration of the severity level for eProsima logging #150

deng02 opened this issue Aug 25, 2017 · 3 comments
Labels
enhancement New feature or request

Comments

@deng02
Copy link
Contributor

deng02 commented Aug 25, 2017

Feature Request

Currently the eProsima logging level is hardcoded to ERROR:
https://github.com/ros2/rmw_fastrtps/blob/master/rmw_fastrtps_cpp/src/rmw_node.cpp#L66

For troubleshooting, it would be useful to be able to change the severity level of the eProsima to INFO or DEBUG, either independently of ROS2 or in conjunction with.

@dirk-thomas
Copy link
Member

I think the best path forward is to implement a custom LogConsumer for FastRTPS which uses the ROS logging API provided by rcutils. Currently rcutils doesn't offer name-specific severity levels but that feature is planned to be added in the future.

If you would like to see this feature rather earlier than later we would appreciate a PR for it.

@dirk-thomas dirk-thomas added the enhancement New feature or request label Aug 25, 2017
@sloretz sloretz added this to the untargeted milestone Mar 8, 2018
@MiguelCompany
Copy link
Collaborator

I think this can be done calling rmw_set_log_severity which in turn calls this

@dirk-thomas
Copy link
Member

Implemented a while ago in #156.

@dirk-thomas dirk-thomas removed this from the untargeted milestone Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants