Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Patching of RTI generated headers/sources very risky #340

Closed
jwillemsen opened this issue Dec 18, 2018 · 5 comments
Closed

Patching of RTI generated headers/sources very risky #340

jwillemsen opened this issue Dec 18, 2018 · 5 comments

Comments

@jwillemsen
Copy link
Contributor

The rmw_connext_cpp project patches the generated RTI files. This is very risky, this is all RTI internal code and can change between versions. It also makes porting of code between vendors much harder because now vendor specific extensions are created

@dirk-thomas
Copy link
Member

Wer are aware that the current approach is fragile. Do you have an alternative proposal?

@jwillemsen
Copy link
Contributor Author

Working slowly on rmw_opendds, hopefully I can make a proposal as part of that

@jwillemsen
Copy link
Contributor Author

Is ros2/rosidl_typesupport_connext#15 improving this?

@dirk-thomas
Copy link
Member

Is ros2/rosidl_typesupport_connext#15 improving this?

No, the IDl pipeline related changes are orthogonal.

@clalancette
Copy link
Contributor

We don't have an alternative at the moment, so we'll close this out for now. If you have an alternative to make this better, please feel free to make a pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants