Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default Incompatible QoS callbacks #533

Closed
mm318 opened this issue Apr 1, 2020 · 3 comments
Closed

Add default Incompatible QoS callbacks #533

mm318 opened this issue Apr 1, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@mm318
Copy link
Member

mm318 commented Apr 1, 2020

Feature request

Feature description

With #459 merged in, a user is able to provide a callback for when an participant on the topic is discovered but unable to be matched due to incompatible QoS policies. This feature request is for leveraging this feature even when a user does not provide a custom callback function, by setting a default callback function that prints a warning (initially suggested at ros2/ros2#822 (comment)) on the discovery of an incompatible participant on the topic.

Implementation considerations

What should the behavior be if the underlying middleware does not support this kind of QoS event callback?

@hidmic
Copy link
Contributor

hidmic commented Apr 8, 2020

@mm318 are you looking forward to implement this feature?

@mm318
Copy link
Member Author

mm318 commented Apr 8, 2020

Hi @hidmic, we already have a pull request opened for this at #536.

@mm318
Copy link
Member Author

mm318 commented Apr 15, 2020

Closing this issue as the related pull request has been merged.

@mm318 mm318 closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants