Fix memory leak. (#828)

* Fix memory leak. Signed-off-by: Lei Liu <[email protected]> Co-authored-by: Chen Lihui <[email protected]> Co-authored-by: Abrar Rahman Protyasha <[email protected]>
ros2 · Sep 30, 2021 · ac13665 · ac13665
1 parent 691e4fb
commit ac13665
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/rclpy/src/rclpy/client.cpp b/rclpy/src/rclpy/client.cpp
@@ -137,8 +137,6 @@ Client::take_response(py::object pyresponse_type)
   result_tuple[0] = header;
 
   result_tuple[1] = convert_to_py(taken_response.get(), pyresponse_type);
-  // result_tuple now owns the message
-  taken_response.release();
 
   return result_tuple;
 }

diff --git a/rclpy/src/rclpy/service.cpp b/rclpy/src/rclpy/service.cpp
@@ -119,7 +119,6 @@ Service::service_take_request(py::object pyrequest_type)
 
   result_tuple[1] = header;
   result_tuple[0] = convert_to_py(taken_request.get(), pyrequest_type);
-  taken_request.release();
 
   return result_tuple;
 }