[rcl_action] changed build_depend and build_depend_export dependencies to depend

[ahcorde]

changed the following <build_depend> and <build_depend_export> to <depend>

• action_msgs
• rcl
• rcutils
• rmw
• rosidl_generator_c

[ahcorde]

But I'm not sure if this package should be <build_depend> and <exec_depend>

[wjwwood]

lgtm with CI

[jacobperron]

I don't think there are execution dependencies on any of these packages, though I don't think there's an issue declaring them as such. Was there something in particular that motivated this change?

[wjwwood]

I don't think there are execution dependencies on any of these packages

Well, my thinking was that if you want to run your package's executable, and your package depends on this package, it should exec depend on it so librcl_action.so/dylib/dll is available at runtime. For the same reason, if librcl_action.* is going to be used, then this package should exec depend on other packages which provide libraries needed at runtime, e.g. librcl.* or librmw.* or shared libraries created by message packages like action_msgs.

Was there something in particular that motivated this change?

I flagged it when I was manually traversing dependencies of rclcpp, rclcpp_actions, and rclcpp_components in prep for the AWS QA work.

[ahcorde]

• Linux
• Linux-aarch64
• macOS
• Windows
• Windows-container

[jacobperron]

if you want to run your package's executable, and your package depends on this package, it should exec depend on it so librcl_action.so/dylib/dll is available at runtime

I hadn't thought about it this way before, but it makes sense to me 👍

[ahcorde]

• Linux
• Linux-aarch64
• macOS
• Windows
• Windows-container

[ahcorde]

Unrelated errors. Merging