add rcl_action_server_is_valid_except_context #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Dec 1, 2018
| RCL_SET_ERROR_MSG("status publisher is invalid"); | ||
| return false; | ||
| } | ||
| return true; |
There was a problem hiding this comment.
Could deduplicate with rcl_action_server_is_valid().
There was a problem hiding this comment.
I'll do this on a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function to check if the action server is valid except for the rcl context and uses it in the wait set apis. This gets rid of an exception thrown by the C++ action server when SIGINT invalidates the context but the wait set tries to check the action server entities and finds that the server has reported itself as invalid.