Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

Regression in rcl_action tests #241

Closed
cottsay opened this issue Sep 18, 2019 · 3 comments · Fixed by ros2/rcl#504
Closed

Regression in rcl_action tests #241

cottsay opened this issue Sep 18, 2019 · 3 comments · Fixed by ros2/rcl#504
Assignees
@ivanpauno

Comments

@cottsay
Copy link
Member

cottsay commented Sep 18, 2019

Messages similar to:

Node name not found: ns='/', name='test_action_graph_old_node_name

Example failures:

  • Build Status
  • Build Status
  • Build Status
@cottsay cottsay transferred this issue from ros2/ci Sep 18, 2019
@cottsay cottsay assigned cottsay and ivanpauno and unassigned cottsay Sep 18, 2019
@cottsay
Copy link
Member Author

cottsay commented Sep 18, 2019

@ivanpauno, I believe that the patch series around ros2/ros2cli#322 regressed these tests. Could you please take a look?

@ivanpauno
Copy link
Member

@ivanpauno, I believe that the patch series around ros2/ros2cli#322 regressed these tests. Could you please take a look?

Yeah, I didn't run rcl_action graph test before merging.
It should be easy to fix.

This was referenced Sep 19, 2019
Merged
Merged
@ivanpauno
Copy link
Member

Fixed by ros2/rcl#504.
@cottsay can you close the issue? I don't have write access here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ivanpauno ivanpauno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rcl_action test_graph ros2/rcl
3 participants
@clalancette @cottsay @ivanpauno