-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ros2 param set /turtlesim background_* needs to be "triggered" #72
Comments
There is no way to change the background color without wiping all previous drawn lines. I am not sure if that is desired - to implicitly clear when changing the parameter? |
I think that's fine because now they'll have to explicitly clear anyway. I'm more concerned with the extra instructions, not what's actually happening. So if it can all be done at once (the clear and the color change) that's better. |
So just to be clear: every time a background color parameter is set the whole scene should be cleared implicitly / automatically? |
I don't think it should be. If there's a way to make it happen without clearing the lines that would be best. But, since you said there is no way to change the color without clearing the drawn lines, I'm fine with the whole screen being cleared as long as the background changes automatically. I will just add a note to the tutorial that the lines will clear - that's much better than the 4 or 5 extra sentences I have now explaining how you have to call |
#75 separates the background color from the painted turtle paths which makes it possible to update the former without resetting the later. Also the background is immediately redrawn when a parameter event occurs. I hope this makes writing the tutorial easier (and also simpler for the users). |
Awesome! Thanks @dirk-thomas. I'll update the parameters tutorial once #75 is merged in |
I'm working through ros2 tutorials at Understanding ROS 2 Parameters |
While a new version was tagged in this repo for Dashing (de7271c) it doesn't seem it was ever released with @claireyywang Can you clarify since you did the upstream release? |
@dirk-thomas honestly I don't remember if I did since it's been a while, but I can do a release now if that's the right move. |
released at ros/rosdistro#25490 |
See the Understanding ROS 2 parameters tutorial discussion.
Setting the background color parameter with
should update the turtlesim window immediately, but it needs to be triggered by calling
because of some leftover functionality from ROS 1.
The text was updated successfully, but these errors were encountered: