Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API incompatibility in RobotStatePublisher::publishFixedTransforms #38

Closed
de-vri-es opened this issue Oct 30, 2015 · 1 comment
Closed

API incompatibility in RobotStatePublisher::publishFixedTransforms #38

de-vri-es opened this issue Oct 30, 2015 · 1 comment

Comments

@de-vri-es
Copy link

Commit 8c27d2b broke backwards compatibility of the C++ interface by adding a bool use_tf_static parameter to the RobotStatePublisher::publishFixedTransforms member function.

Adding a default value to either true or false will fix the incompatibility. If filling in a default is undesirable, we could add a deprecated overload that fills in the boolean value.

Either way, breaking the C++ API within a the same ROS release is a bit messy.
@de-vri-es de-vri-es changed the title API incompatibility in RobotStatePublisher::publishFIxedTransforms API incompatibility in RobotStatePublisher::publishFixedTransforms Oct 30, 2015
@scpeters
Copy link
Contributor

scpeters commented Dec 9, 2015

I'm working on this

@scpeters scpeters mentioned this issue Dec 9, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@de-vri-es @scpeters