Install includes to include/${PROJECT_NAME}

[sloretz]

Part of ros2/ros2#1150
Part of ament/ament_cmake#365

This installs includes to another package specific include prefix. This avoids include directory search order issues that can happen when overriding packages in a merged underlay workspace.

I also made it export a modern CMake target instead of old style CMake variables.

[sloretz]

CI (build: --packages-above-and-dependencies robot_state_publisher test: --packages-select robot_state_publisher)

• Linux
• Linux-aarch64
• macOS
• Windows

[sloretz]

Not sure what the cause of windows CI failing is. I'll come back and investigate

13:18:41 component_container_isolated.obj : error LNK2001: unresolved external symbol "protected: virtual void __cdecl rclcpp_components::ComponentManagerIsolated<class rclcpp::executors::MultiThreadedExecutor>::add_node_to_executor(unsigned __int64)" (?add_node_to_executor@?$ComponentManagerIsolated@VMultiThreadedExecutor@executors@rclcpp@@@rclcpp_components@@MEAAX_K@Z) [C:\ci\ws\build\rclcpp_components\component_container_isolated.vcxproj]

13:18:41 component_container_isolated.obj : error LNK2001: unresolved external symbol "protected: virtual void __cdecl rclcpp_components::ComponentManagerIsolated<class rclcpp::executors::SingleThreadedExecutor>::add_node_to_executor(unsigned __int64)" (?add_node_to_executor@?$ComponentManagerIsolated@VSingleThreadedExecutor@executors@rclcpp@@@rclcpp_components@@MEAAX_K@Z) [C:\ci\ws\build\rclcpp_components\component_container_isolated.vcxproj]

13:18:41 component_container_isolated.obj : error LNK2001: unresolved external symbol "protected: virtual void __cdecl rclcpp_components::ComponentManagerIsolated<class rclcpp::executors::MultiThreadedExecutor>::remove_node_from_executor(unsigned __int64)" (?remove_node_from_executor@?$ComponentManagerIsolated@VMultiThreadedExecutor@executors@rclcpp@@@rclcpp_components@@MEAAX_K@Z) [C:\ci\ws\build\rclcpp_components\component_container_isolated.vcxproj]

13:18:41 component_container_isolated.obj : error LNK2001: unresolved external symbol "protected: virtual void __cdecl rclcpp_components::ComponentManagerIsolated<class rclcpp::executors::SingleThreadedExecutor>::remove_node_from_executor(unsigned __int64)" (?remove_node_from_executor@?$ComponentManagerIsolated@VSingleThreadedExecutor@executors@rclcpp@@@rclcpp_components@@MEAAX_K@Z) [C:\ci\ws\build\rclcpp_components\component_container_isolated.vcxproj]

13:18:41 C:\ci\ws\build\rclcpp_components\Release\component_container_isolated.exe : fatal error LNK1120: 4 unresolved externals [C:\ci\ws\build\rclcpp_components\component_container_isolated.vcxproj]

[clalancette]

Windows failures aside, I'm good with the general idea of this. Though I would like to see a bunch of these types of PRs get merged at the same time, so I'd want to see more of the packages listed in ros2/ros2#1150 (comment) done before merging this.

[sloretz]

Though I would like to see a bunch of these types of PRs get merged at the same time

I would recommend trialing this on a small number of packages and releasing them to Rolling first. That would give early warning if there's a problem without having to work on and then revert a bunch of PRs

[clalancette]

I would recommend trialing this on a small number of packages and releasing them to Rolling first. That would give early warning if there's a problem without having to work on and then revert a bunch of PRs

All right, that's fair enough.

By the way, the failing Windows build may have been unrelated to this PR and may have been fixed by ros2/rclcpp#1843 . So I'd recommend kicking it off again.

[sloretz]

Windows CI re-run