fix types in range loops to avoid copy due to different type #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <[email protected]>
sloretz
reviewed
Jul 14, 2020
There was a problem hiding this comment.
The change LGTM from a functional perspective, but I'll let co-maintainer @clalancette chime in since I know auto has been intentionally avoided for clarity.
dirk-thomas
changed the title
clalancette
approved these changes
Jul 15, 2020
|
Can this be backported to Foxy? |
I don't see a reason why not. |
Karsten1987
pushed a commit
to Karsten1987/robot_state_publisher
that referenced
this pull request
Sep 25, 2020
* use auto in range loops to avoid copy due to different type Signed-off-by: Dirk Thomas <[email protected]> * avoid auto, use explicit correct type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/482/gcc/folder.1581101687/
After:
Regular CI builds testing the downstream packages (only with FastRTPS):