[FindPoco.cmake] Only use 'd' suffix when debug libraries are present. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of Debian and Ubuntu (beginning with Stretch and Bionic respectively) do not provide separate debug library versions of Poco. The refactored debug check now actually verifies that a d-suffixed library exists. If not it falls back to using the non-suffixed version of the library which may or may not include debug symbols.
This was referenced Mar 19, 2019
wjwwood
approved these changes
Mar 19, 2019
|
@nuclearsandwich should this be merged and released now? |
I think it should probably at least be released into Melodic as it's preventing debug builds with class_loader from succeeding. But I don't think it's important that it be released in any earlier distro unless it's easier than releasing to just Melodic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of Debian and Ubuntu (beginning with Stretch and Bionic respectively) do not provide separate debug library versions of Poco.
The refactored debug check now actually verifies that a d-suffixed library exists. If not it falls back to using the non-suffixed version of the library which may or may not include debug symbols.
This change resolves #49 and ros/class_loader#117
As far as targeting for this PR. I've tested it naively on Xenial and Bionic so in theory it's backwards compatible enough to be released in earlier ROS releases without impact but I don't think that it brings value to systems earlier than Stretch and Bionic. It may also be worth deprecating the FindPoco.cmake module as both Debian and Ubuntu are distributing Poco with a CMake find module as of Buster and Bionic respectively.