Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreliable option on image, camera and map #976

Merged

Conversation

joao-avelino
Copy link
Contributor

When streaming videos it's usually a good idea to do it using UDP. This is specially true if we are connected through Wi-Fi or other "unreliable" connection.

Since we were having problems visualizing the streams coming from our robot over Wi-Fi, we decided to make the Unreliable (UDP) option also available for Image and Camera displays. We also made it available for Map.

@wjwwood
Copy link
Member

wjwwood commented Mar 13, 2016

@joao-avelino have you seen #971?

@joao-avelino
Copy link
Contributor Author

Hey there, @wjwwood!

Yes, I've seen #971, and this changes are based on it. #971 doesn't make the option available for Image and Camera displays, since they don't inherit from "MessageFilterDisplay" where the "unreliable option" is implemented in #971.

That's also true for the Map Display.

@NikolausDemmel
Copy link
Contributor

I'm not sure what the Relation to MessageFilterDisplay is (i.e. should Camerw/Image/Map use MessageFilterDisplay), but the patch seems simple enough as it is.

I haven't tested it yet, but I would want to use it next time I am in the field with flaky WiFi, so +1.

@wjwwood
Copy link
Member

wjwwood commented Mar 18, 2016

@joao-avelino got it. I tested this and it looks good. Thanks!

wjwwood added a commit that referenced this pull request Mar 18, 2016
Unreliable option on image, camera and map
@wjwwood wjwwood merged commit 0b4bdb5 into ros-visualization:indigo-devel Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants