Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions when creating publishers in tools #1467

Merged
merged 1 commit into from
Feb 8, 2020

Conversation

rhaschke
Copy link
Contributor

Fix #1466: An invalid ros topic name caused rviz to crash due to the uncaught exception.

Copy link
Contributor

@simonschmeisser simonschmeisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even more fancy would be showing some visual feedback :)

@rhaschke
Copy link
Contributor Author

rhaschke commented Feb 8, 2020

For now, this needs to be sufficient. I don't have the (time) resources to provide visual feedback now.
I thought about indicating an error via a red background in the input field. But this will involve ABI changes: properties need to have an additional boolean flag to indicate the error condition. Then getViewData() can return the corresponding background color. Probably, it would be great to provide the error message as well, e.g. as a tooltip.

@rhaschke rhaschke merged commit de383ee into ros-visualization:melodic-devel Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Crash upon entering an invalid topic name (ros::InvalidNameException)
2 participants