Fix for 1120 #1132
Merged
Fix for 1120 #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes regression of #1084
|
I should note that the first row of items in the above matrix of test markers only has something in the first column. The other columns are empty, though I might update the tool again to fill the spots out, just for completeness. |
even though the previously missing ones would be invisible in the correct behavior
|
41bf5e2 adds the missing mesh markers to the matrix, but it doesn't affect the screen shot as they are invisible due to alpha of 0. |
|
@ros-pull-request-builder retest this please |
wjwwood
added a commit
that referenced
this pull request
Aug 21, 2017
* improve mesh marker test tool * fix first time color on mesh markers fixes regression of #1084 * fill out matrix of mesh markers even though the previously missing ones would be invisible in the correct behavior * remove travis in favor of build.ros.org pr testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1120.
Basically #1084 caused a regression that caused markers which had a mesh text and color to render white until the color or alpha was updated, after which point it would render correctly.
I also improved the marker mesh test executable to test a few of these things. Here's a screen shot of the behavior with this pr (the correct behavior imo):