Adding a warning for VGA resolution for depth camera #93
Conversation
src/converters/camera.cpp
Outdated
| @@ -99,6 +99,7 @@ const sensor_msgs::CameraInfo& getCameraInfo( int camera_source, int resolution | |||
| if ( resolution == AL::kVGA ) | |||
| { | |||
| static const sensor_msgs::CameraInfo cam_info_msg = createCameraInfoDEPTHVGA(); | |||
| ROS_WARN("VGA resolution is not supported for the depth camera, please use QVGA"); | |||
There was a problem hiding this comment.
As this is logging it should include the the ros header with the logging macros.
Should we rephrase to say QVGA or lower ? (is QQVGA a valid resolution for the depth camera on pepper ?)
There was a problem hiding this comment.
True that there are no ROS_WARN in Naoqi Driver, it seems that they have preferred to use std::cout.
What kind of macros do you mean? #include <ros/console.h> ?
Agree for "QVGA or lower"
There was a problem hiding this comment.
What kind of macros do you mean? #include <ros/console.h> ?
yep 👍
Agree for "QVGA or lower"
👍
|
thanks! fixed in a new commit |
| @@ -27,6 +27,7 @@ | |||
| * ROS includes | |||
| */ | |||
| #include <cv_bridge/cv_bridge.h> | |||
| #include <ros/console.h> | |||
There was a problem hiding this comment.
I think you will have to add rosconsole to the package.xml as a dependency
👍 One more comment about dependency declaration otherwise I think this is ready to be merged! |
nlyubova
force-pushed
the
fix_VGA_warning
branch
2 times, most recently
from
5ec00ee to
9489698
Compare
|
done, in the same commit with fix. |
package.xml
Outdated
| @@ -28,6 +28,7 @@ | |||
| <build_depend>tf2_geometry_msgs</build_depend> | |||
| <build_depend>tf2_msgs</build_depend> | |||
| <build_depend>tf2_ros</build_depend> | |||
| <build_depend>rosconsole</build_depend> | |||
There was a problem hiding this comment.
thanks for the quick fix, one tiny comment: can you place it in alphabetical order in the list ? (it looks like all the other deps are ordered alphabetically) Same below for the run_depend
nlyubova
force-pushed
the
fix_VGA_warning
branch
from
9489698 to
fd40a81
Compare
nlyubova
force-pushed
the
fix_VGA_warning
branch
from
fd40a81 to
298aece
Compare
|
just moved it according to the order |
|
squash ? |
Yep, you can use the "Squash and Merge" button from the github UI (arrow next to "Merge pull request") |
@mikaelarguedas finally, the warning is available :)