-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add services for get and set language #87
Conversation
src/helpers/driver_helpers.cpp
Outdated
|
||
robot_url = session->url(); | ||
|
||
// Get the robot type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
memo: need to modify this
src/helpers/driver_helpers.cpp
Outdated
|
||
robot_url = session->url(); | ||
|
||
// Get the robot type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
memo: need to modify this
+1 fine for me. @suryaambrose what do you think? |
@kochigami can you do a pull request with a data format to nao_interaction? |
I'm sorry for my late response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me!
Let's keep them in naoqi_bridge_msgs as it is.
confirmed with:
|
I found there are some errors when executing it with ros kinetic (both NAO and Pepper). I will report and update tomorrow. |
Thank you so much for testing! |
I'm trying to fix this pull-request, but it may take a long time... problem: status:
I found
|
I modified my pull request as for the problem above. I confirmed with:
|
cb22750
to
c6565d6
Compare
Thank you! |
reference: http://doc.aldebaran.com/2-4/naoqi/audio/altexttospeech-api.html#altexttospeech-api
ALTextToSpeechProxy::setLanguage
andALTextToSpeechProxy::getLanguage
requires: ros-naoqi/naoqi_bridge_msgs#32
I tried it with pepper, naoqi 2.5.5.5, ros indigo