-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/stereo #111
Feature/stereo #111
Conversation
… call them in the getCameraInfo method
hey, great that you've done it ! |
Thanks for contribution! Could you add somewhere a debug message telling the user which version of the robot has been detected? (like 'Pepper 1.8', 'Pepper 1.6', 'Pepper 1.8a', etc) |
You're welcome, we needed it anyway, so why not share it with the community :) Sure, I could add that in the initial logs |
@nlyubova any chance you can test the code before we merge? |
@severin-lemaignan Sorry, I don’t have Pepper. |
I was able to test it on a Pepper 1.8 and on a Pepper 1.8A, it was working fine. If an additional tester is required, I think that @zygopter could have access to some Peppers :) |
We'll trust you on that one ;-) Merging now. Thanks! |
On Pepper 1.8, the depth information is reconstructed from the stereo information provided by 2 RGB cameras (each RGB camera is located behind each eye, the left eye is used as referential).
This PR makes naoqi_driver compatible with Pepper 1.8 and ensures its compatibility with the previous versions of the robot. On a 1.8 robot, the user will now be able to access to: