Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Part 3.2 not up-to-date. #331

Open
JoeGre666 opened this issue Nov 9, 2020 · 2 comments
Open

Tutorial Part 3.2 not up-to-date. #331

JoeGre666 opened this issue Nov 9, 2020 · 2 comments

Comments

@JoeGre666
Copy link

Hey, I'm currently trying to do ROS Industrial (Melodic) Training Exercises 3.2. I did everything as in the instructions, but always got errors. According to the error message there is no buffer.h / transform_listener.h in the package tf2, so I looked it up and found the matching header files in the tf2_ros package (look at instructions).

Screenshot from 2020-11-09 18-04-09

So I tried including those packages, still errors. After a few more tries I looked in the exercise-files and found out that I was right about the tf2_ros-package, but additionally the <tf2_geometry_msgs/tf2_geometry_msgs.h> header-file is missing (screenshot is from exercise files - for reference). This is not mentioned in the instructions at all.

Screenshot from 2020-11-09 18-02-09

Since I was a bit frustrated, I suggest to maybe adjust this? :)
Apart from that - great tutorial.
Kind regards,
Johannes

@basalp
Copy link

basalp commented Jan 30, 2021

Thank you for the suggestions, this is really helpful. Without the <tf2_geometry_msgs/tf2_geometry_msgs.h> package, the catkin build was complaining for a reason that I did not understand for a while. Addition of it solved the issue. With that, explicit #include <geometry_msgs/PoseStamped.h> becomes obsolete as the former package also includes it.

@marip8
Copy link
Member

marip8 commented Feb 1, 2021

Thanks for catching this issue. It seems like we actually changed the solution to the exercise here to be correct, but we didn't catch the header references in the exercise documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants