Added diagnostics to the URG Node. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I was on vacation, so I won't be able to merge this for a little while. This will go into hydro, so we have some time. |
|
"And then I forgot about this." I'll get this into Hydro. |
chadrockey
added a commit
that referenced
this pull request
Aug 22, 2013
Added diagnostics to the URG Node.
Karsten1987
referenced
this pull request
in bosch-robotics-na/urg_node
Jun 16, 2019
Install urg_node executable into lib/urg_node instead of bin Closes issue #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a cut at adding diagnostics to the new URG node.
I had to add some caching for the non-const accessors in the URG wrapper. If you poll on those too often (as diagnostics_updater does) while the laser is scanning, it will cause failures.
Also added an isRunning() convenience function.