Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should new review issue instructions specify to change the "Name" field? #101

Open
mikemahoney218 opened this issue Mar 30, 2024 · 0 comments
Assignees

Comments

@mikemahoney218
Copy link
Member

mikemahoney218 commented Mar 30, 2024

The top of a new review issue reads:

Below, please enter values for (1) submitting author GitHub handle (replacing "@github_handle@); and (2) Repository URL (replacing "https://repourl"). Values for additional package authors may also be specified, replacing "@github_handle1", "@github_handle2" - delete these if not needed. DO NOT DELETE HTML SYMBOLS (everything between "<!" and ">"). Replace only "@github_handle" and "https://repourl". This comment may be deleted once it has been read and understood.

The first field though is:

Submitting Author Name: Name

Which isn't mentioned as one of the values to change. Should this read:

Below, please enter values for (1) submitting author name (replacing "Name"); (2) submitting author GitHub handle (replacing "@github_handle@); and (3) Repository URL (replacing "https://repourl"). Values for additional package authors may also be specified, replacing "@github_handle1", "@github_handle2" - delete these if not needed. DO NOT DELETE HTML SYMBOLS (everything between "<!" and ">"). Replace only "Name", "@github_handle", and "https://repourl". This comment may be deleted once it has been read and understood.

Skimming over the last few issues, it seems like I was the only person tripped up by this -- I think I'm too much of a rules follower! 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants