[CLN] LNBits backed by C-lightning #2556

openoms · 2021-09-20T11:01:10Z

The configuration changes are simple, but needs testing: https://github.com/lnbits/lnbits/blob/master/docs/guide/wallets.md#clightning

rootzoll · 2021-09-20T11:08:21Z

Will be do this like with RTL ... having a LNbits & a cLNbits or will this be a selector within the LNbits options/menus somehow?

Also we should use this refactor to change the LNbits service to a prestart script for ad-hoc configuration like RTL or BTC-RPC-Explorer.

rootzoll · 2021-12-04T10:04:29Z

OK ... first I tought lets make two LNbits installations one for lnd and one for c-lightning - like we did for RTL. But came to the conclusion that it just makes sense to have one LNbits installation that takes just one funding source that can be switched. That way even an already running LNbits with accounts is flexible to just change the funding source. Also its easier with all the IP2Tor to just have one instance - thats less confusing.

So in general - apps like RTL that are needed to manage a node makes sense to have an instance each for LND & c-lightning. But apps that work on-top and can work with both makes sense to have just one instance and make it easy to switch what node should run in the background.

rootzoll · 2021-12-07T01:11:01Z

OK - ready for testing in branch: https://github.com/rootzoll/raspiblitz/tree/2556cLNbits .. also test recovery for an LNbits switched to cl.

To be looked at on a side note:

LNbits raspiblitz tag is on an stable but quite old April sate - maybe update? Install still works?
with LND the copied macaroons from /mnt/hdd/app-data/lnd/data are used ... maybe let background process also check if those macaroons changed and need updating?

rootzoll · 2021-12-16T19:14:42Z

OK merged now into dev branch. On test switching from LND to c-lightning as a LNbits backend I got this error again:

Dec 16 19:06:37 testblitz bonus.lnbits.sh[1441530]: # OK: prestart finished
Dec 16 19:06:37 testblitz systemd[1]: Started lnbits.
Dec 16 19:06:39 testblitz sh[1441545]: Traceback (most recent call last):
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/./venv/bin/hypercorn", line 8, in <module>
Dec 16 19:06:39 testblitz sh[1441545]:     sys.exit(main())
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/venv/lib/python3.9/site-packages/hypercorn/__main__.py", line 267, in main
Dec 16 19:06:39 testblitz sh[1441545]:     run(config)
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/venv/lib/python3.9/site-packages/hypercorn/run.py", line 34, in run
Dec 16 19:06:39 testblitz sh[1441545]:     worker_func(config)
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/venv/lib/python3.9/site-packages/hypercorn/trio/run.py", line 113, in trio_worker
Dec 16 19:06:39 testblitz sh[1441545]:     app = load_application(config.application_path)
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/venv/lib/python3.9/site-packages/hypercorn/utils.py", line 110, in load_application
Dec 16 19:06:39 testblitz sh[1441545]:     module = import_module(import_name)
Dec 16 19:06:39 testblitz sh[1441545]:   File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
Dec 16 19:06:39 testblitz sh[1441545]:     return _bootstrap._gcd_import(name[level:], package, level)
Dec 16 19:06:39 testblitz sh[1441545]:   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
Dec 16 19:06:39 testblitz sh[1441545]:   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
Dec 16 19:06:39 testblitz sh[1441545]:   File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
Dec 16 19:06:39 testblitz sh[1441545]:   File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
Dec 16 19:06:39 testblitz sh[1441545]:   File "<frozen importlib._bootstrap_external>", line 790, in exec_module
Dec 16 19:06:39 testblitz sh[1441545]:   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/lnbits/app.py", line 11, in <module>
Dec 16 19:06:39 testblitz sh[1441545]:     from .commands import db_migrate, handle_assets
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/lnbits/commands.py", line 8, in <module>
Dec 16 19:06:39 testblitz sh[1441545]:     from .db import SQLITE, POSTGRES, COCKROACH
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/lnbits/db.py", line 11, in <module>
Dec 16 19:06:39 testblitz sh[1441545]:     from .settings import LNBITS_DATA_FOLDER, LNBITS_DATABASE_URL
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/lnbits/settings.py", line 46, in <module>
Dec 16 19:06:39 testblitz sh[1441545]:     WALLET = wallet_class()
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/lnbits/wallets/clightning.py", line 48, in __init__
Dec 16 19:06:39 testblitz sh[1441545]:     invoices = self.ln.listinvoices()
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/venv/lib/python3.9/site-packages/lightning/lightning.py", line 630, in listinvoices
Dec 16 19:06:39 testblitz sh[1441545]:     return self.call("listinvoices", payload)
Dec 16 19:06:39 testblitz sh[1441545]:   File "/home/lnbits/lnbits/venv/lib/python3.9/site-packages/lightning/lightning.py", line 217, in call
Dec 16 19:06:39 testblitz sh[1441545]:     sock.connect(self.socket_path)
Dec 16 19:06:39 testblitz sh[1441545]: PermissionError: [Errno 13] Permission denied
Dec 16 19:06:39 testblitz systemd[1]: lnbits.service: Main process exited, code=exited, status=1/FAILURE

With CLIGHTNING_RPC=/home/bitcoin/.lightning/bitcoin/lightning-rpc in LNbits config while

[email protected]:~ ₿ sudo ls -la /home/bitcoin/.lightning/bitcoin/lightning-rpc
srw-rw---- 1 bitcoin bitcoin 0 Dec 16 10:08 /home/bitcoin/.lightning/bitcoin/lightning-rpc

[email protected]:~ ₿ sudo ls -la /home/bitcoin/.lightning/
total 20
drwxr-xr-x  3 bitcoin bitcoin 4096 Dec 14 18:56 .
drwxr-xr-x 10 bitcoin bitcoin 4096 Dec 16 18:47 ..
drwxrwx---  2 bitcoin bitcoin 4096 Dec 16 18:58 bitcoin
-rw-r--r--  1 bitcoin bitcoin  267 Dec 14 18:53 config
-rw-r-----  1 bitcoin bitcoin    7 Dec 16 10:07 lightningd-bitcoin.pid

To be restested on a fresh install.

rootzoll · 2021-12-21T20:47:27Z

lnbits switched to fastAPI branch - needs update on commit and restest

rootzoll · 2021-12-23T12:44:12Z

Opened 2556lnbits branch

rootzoll · 2021-12-23T13:02:39Z

OK change to fastAPI seems to work - merging branch into dev for final testing.

openoms · 2022-02-05T19:57:09Z

if during the provision the c-lightning was not run yet the lightning-rpc socket does not exist (or might be recreated)
so lnbits will not be able to read and error out with

File "/home/lnbits/lnbits/venv/lib/python3.9/site-packages/lightning/lightning.py", line 630, in listinvoices
return self.call("listinvoices", payload)
File "/home/lnbits/lnbits/venv/lib/python3.9/site-packages/lightning/lightning.py", line 217, in call
PermissionError: [Errno 13] Permission denied

Confirmed:

$ sudo ls -la /home/bitcoin/.lightning/bitcoin${clrpcsubdir}/lightning-rpc
srw------- 1 bitcoin bitcoin 0 Feb  5 19:40 /home/bitcoin/.lightning/bitcoin/lightning-rpc

$ groups lnbits
lnbits : lnbits
$ groups bitcoin
bitcoin : bitcoin debian-tor

[email protected]:~ ₿

Solved with :

sudo chmod 660 /home/bitcoin/.lightning/bitcoin${clrpcsubdir}/lightning-rpc
# also (is this running too early after creating the user?):
sudo /usr/sbin/usermod --append --groups bitcoin lnbits
sudo systemctl restart lnbits

rootzoll · 2022-02-06T11:46:25Z

if during the provision the c-lightning was not run yet the lightning-rpc socket does not exist (or might be recreated)
so lnbits will not be able to read and error out with

So do I understand that right, that the c-lightning needs to run first (at least once) to create the lightning-rpc socket that lnbits needs on installation? So one solution could be to put the needed configuration into the pre-start script of ln bits?

openoms · 2022-02-06T12:43:59Z

Yes, but the limitation of the prestart scripts is that they are running with the unprivileged user (rightly) so cannot modify ownership or user groups.

Might be able to make it the part of the c-lightning prestart, will need to check.

#2556

openoms · 2022-02-06T20:10:16Z

Relaxed the permission of the lightning-rpc socket by default to group readable. This make sense for other apps too, like C_lightningREST can be run with it's separate user instead of bitcoin as well.

Also added some debug checks to catch if lnbits is not added to the bitcoin group: 04a3a5a

openoms · 2022-02-09T19:04:33Z

do weird.
During install:

# Running: 'bonus.lnbits.sh on cl'
*** Add the 'lnbits' user ***
Adding user `lnbits' ...
Adding new group `lnbits' (1003) ...
Adding new user `lnbits' (1003) with group `lnbits' ...
Creating home directory `/home/lnbits' ...
Copying files from `/etc/skel' ...
# add the 'lnbits' user to the 'bitcoin' group
# check user
uid=1003(lnbits) gid=1003(lnbits) groups=1003(lnbits),1002(bitcoin)
# get the github code user(lnbits) branch(3ae6ef25a1fce6fc53d444c9352e4fe7972ed9a3)
Cloning into 'lnbits'...
remote: Enumerating objects: 19193, done.
remote: Counting objects: 100% (921/921), done.

the checking afterwards:

₿ id lnbits
uid=1003(lnbits) gid=1003(lnbits) groups=1003(lnbits)

something must remove it from the bitcoin group

openoms · 2022-02-09T19:30:44Z

now it works!

rootzoll · 2022-02-17T12:47:07Z

OK testing looks goog - closing issue for release.

c35cr15p · 2022-03-02T02:18:39Z

Hi everyone,
I am getting an error similar to the one described in my raspiblitz installation.
I used the solutions that are described in the issue but it didn't work.
I am using the Raspiblitz software version 1.7.2.
I attach the log and the lnbits image.
Can you help me solve this problem on my node.
If you need any more information, I am at your disposal.
Thank you in advance.
Cesar Crisp

lnbits.log

raspiblitz.log

openoms added this to the 1.8 Release milestone Sep 20, 2021

openoms mentioned this issue Sep 20, 2021

C-lightning on the RaspiBlitz #2295

Closed

rootzoll modified the milestones: 1.8 Release, 1.7.2 Release Oct 26, 2021

rootzoll added the final testing was fixed - needs testing label Dec 7, 2021

rootzoll added a commit that referenced this issue Dec 16, 2021

fix #2792 & #2556 LNbits c-lightning (#2808)

88d77d4

rootzoll added a commit that referenced this issue Dec 21, 2021

#2556 lnbits switch to fastAPI

67878d8

rootzoll added a commit that referenced this issue Dec 23, 2021

#2556 change to uvicorn

74dc6e6

rootzoll added a commit that referenced this issue Dec 23, 2021

#2556 change to uvicorn (#2844)

3e83191

rootzoll added bug - confirmed Something isn't working and can be reproduced and removed final testing was fixed - needs testing labels Feb 6, 2022

openoms added a commit that referenced this issue Feb 6, 2022

cl.check: make the lightning-rpc socket group readable

96ba0ee

#2556

openoms mentioned this issue Feb 6, 2022

[CL] [refactoring] Dedicated user for C-lightningREST and Spark #2932

Closed

openoms added a commit that referenced this issue Feb 9, 2022

#2556 modify usergroup as part of switch

8073072

openoms added final testing was fixed - needs testing and removed bug - confirmed Something isn't working and can be reproduced labels Feb 9, 2022

rootzoll removed the final testing was fixed - needs testing label Feb 17, 2022

rootzoll closed this as completed Feb 17, 2022

c35cr15p mentioned this issue Mar 2, 2022

C_Lightning Error #3010

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CLN] LNBits backed by C-lightning #2556

[CLN] LNBits backed by C-lightning #2556

openoms commented Sep 20, 2021

rootzoll commented Sep 20, 2021

rootzoll commented Dec 4, 2021 •

edited

Loading

rootzoll commented Dec 7, 2021 •

edited

Loading

rootzoll commented Dec 16, 2021 •

edited

Loading

rootzoll commented Dec 21, 2021

rootzoll commented Dec 23, 2021

rootzoll commented Dec 23, 2021

openoms commented Feb 5, 2022

rootzoll commented Feb 6, 2022

openoms commented Feb 6, 2022 •

edited

Loading

openoms commented Feb 6, 2022

openoms commented Feb 9, 2022

openoms commented Feb 9, 2022

rootzoll commented Feb 17, 2022

c35cr15p commented Mar 2, 2022 •

edited

Loading

[CLN] LNBits backed by C-lightning #2556

[CLN] LNBits backed by C-lightning #2556

Comments

openoms commented Sep 20, 2021

rootzoll commented Sep 20, 2021

rootzoll commented Dec 4, 2021 • edited Loading

rootzoll commented Dec 7, 2021 • edited Loading

rootzoll commented Dec 16, 2021 • edited Loading

rootzoll commented Dec 21, 2021

rootzoll commented Dec 23, 2021

rootzoll commented Dec 23, 2021

openoms commented Feb 5, 2022

rootzoll commented Feb 6, 2022

openoms commented Feb 6, 2022 • edited Loading

openoms commented Feb 6, 2022

openoms commented Feb 9, 2022

openoms commented Feb 9, 2022

rootzoll commented Feb 17, 2022

c35cr15p commented Mar 2, 2022 • edited Loading

rootzoll commented Dec 4, 2021 •

edited

Loading

rootzoll commented Dec 7, 2021 •

edited

Loading

rootzoll commented Dec 16, 2021 •

edited

Loading

openoms commented Feb 6, 2022 •

edited

Loading

c35cr15p commented Mar 2, 2022 •

edited

Loading