Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popper not working in Beta 4 #1945

Closed
5 of 6 tasks
MWDelaney opened this issue Aug 12, 2017 · 0 comments
Closed
5 of 6 tasks

Popper not working in Beta 4 #1945

MWDelaney opened this issue Aug 12, 2017 · 0 comments

Comments

@MWDelaney
Copy link
Member

Submit a feature request or bug report


What is the current behavior?

Popper (required by Bootstrap 4 Beta for dropdowns) is not working in Sage9 Beta 4. I banged my head against an existing theme I'd ported into Beta 4 for a while with no luck, and eventually tried a plain vanilla Beta 4 and found the same results.

Upon clicking a dropdown trigger, I get the following message:

TypeError: Object is not a constructor (evaluating 'new Popper(element, this._menu, this._getPopperConfig())')

I tried importing Popper in main.js and nothing changed.

What is the expected or desired behavior?

Popper should work, as it's required for Bootstrap 4 functionality.


Bug report

Please provide steps to reproduce, including full log output:

  1. Install a fresh copy of Sage9 Beta 4 with composer, run basic setup and yarn steps
  2. Add the following Bootstrap 4 example code to a view:
<div class="dropdown">
  <button class="btn btn-secondary dropdown-toggle" type="button" id="dropdownMenuButton" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
    Dropdown button
  </button>
  <div class="dropdown-menu" aria-labelledby="dropdownMenuButton">
    <a class="dropdown-item" href="#">Action</a>
    <a class="dropdown-item" href="#">Another action</a>
    <a class="dropdown-item" href="#">Something else here</a>
  </div>
</div>
  1. Rerun yarn build and see the console errors when you try to trigger the dropdown.

Please describe your local environment:

WordPress version: 4.8.1

OS: MacOS X

NPM/Node version: v7.4.0

Where did the bug happen? Development or remote servers?

Development

Is there a related Discourse thread or were any utilized (please link them)?

No


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants