Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs about fields scrubbed by default are inaccurate. #507

Closed
serhalp opened this issue Nov 20, 2017 · 5 comments
Closed

Docs about fields scrubbed by default are inaccurate. #507

serhalp opened this issue Nov 20, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@serhalp
Copy link

serhalp commented Nov 20, 2017

The docs here claim:

Default: ["passwd", "password", "secret", "confirm_password", "password_confirmation"]

but the source code claims otherwise - there are 35 fields scrubbed by default on servers and 14 in browsers.

In addition the docs make no mention of this browser/server difference.

@rivkahstandig3636
Copy link
Contributor

Thanks for the feedback! We'll update the docs.

@rivkahstandig3636 rivkahstandig3636 self-assigned this Dec 27, 2017
@rivkahstandig3636 rivkahstandig3636 added this to the v2.3.8 milestone Jan 18, 2018
@rivkahstandig3636
Copy link
Contributor

@rokob It's unclear to me if we do in fact need to update our documentation here or if this has been fixed.

@rokob
Copy link
Contributor

rokob commented Feb 1, 2018

The docs need to be updated

@rivkahstandig3636
Copy link
Contributor

Okay thanks, I'll make a note to update these.

@rivkahstandig3636
Copy link
Contributor

Closed via #570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants