From c7016f08027984dc10180b11eb69a86ab5dfc618 Mon Sep 17 00:00:00 2001
From: Paul Dreik <github@pauldreik.se>
Date: Fri, 13 Dec 2024 10:57:47 +0100
Subject: [PATCH 1/4] remove const on return value

when returning by value, the const qualifier is ignored.
---
 include/OsqpEigen/Solver.hpp | 2 +-
 src/Solver.cpp               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/OsqpEigen/Solver.hpp b/include/OsqpEigen/Solver.hpp
index f6072b0..8afe685 100644
--- a/include/OsqpEigen/Solver.hpp
+++ b/include/OsqpEigen/Solver.hpp
@@ -176,7 +176,7 @@ class Solver
      * Get the primal objective value
      * @return The primal objective value
      */
-    const c_float getObjValue() const;
+    c_float getObjValue() const;
 
     /**
      * Get the optimization problem solution.
diff --git a/src/Solver.cpp b/src/Solver.cpp
index 87715f8..e01a6d8 100644
--- a/src/Solver.cpp
+++ b/src/Solver.cpp
@@ -193,7 +193,7 @@ OsqpEigen::Status OsqpEigen::Solver::getStatus() const
     return static_cast<OsqpEigen::Status>(getInfo()->status_val);
 }
 
-const c_float OsqpEigen::Solver::getObjValue() const
+c_float OsqpEigen::Solver::getObjValue() const
 {
     return getInfo()->obj_val;
 }

From aa8f16015e1188da93b242b42b4a9a22d3273047 Mon Sep 17 00:00:00 2001
From: Paul Dreik <github@pauldreik.se>
Date: Fri, 13 Dec 2024 10:59:36 +0100
Subject: [PATCH 2/4] fix warning about unused value

---
 src/Debug.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Debug.cpp b/src/Debug.cpp
index cd6f702..82dbcaf 100644
--- a/src/Debug.cpp
+++ b/src/Debug.cpp
@@ -22,7 +22,7 @@ class NullStream : public std::ostream
     }
 };
 
-template <class T> const NullStream& operator<<(NullStream&& os, const T& value)
+template <class T> const NullStream& operator<<(NullStream&& os, const T&)
 {
     return os;
 }

From 4cd09deccf0b2415362c82b74fc4906a270c2a0e Mon Sep 17 00:00:00 2001
From: Paul Dreik <github@pauldreik.se>
Date: Fri, 13 Dec 2024 11:00:41 +0100
Subject: [PATCH 3/4] enable compiler warnings

---
 CMakeLists.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index b92d8e1..881b8eb 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -110,6 +110,8 @@ add_library(${LIBRARY_TARGET_NAME} ${${LIBRARY_TARGET_NAME}_SRC} ${${LIBRARY_TAR
 target_include_directories(${LIBRARY_TARGET_NAME} PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>"
   "$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>")
 
+ADD_WARNINGS_CONFIGURATION_TO_TARGETS(PRIVATE TARGETS ${LIBRARY_TARGET_NAME})
+
 target_link_libraries(${LIBRARY_TARGET_NAME} PUBLIC osqp::osqp Eigen3::Eigen)
 if(OSQP_IS_V1)
   target_compile_definitions(${LIBRARY_TARGET_NAME} PUBLIC OSQP_EIGEN_OSQP_IS_V1)

From 39eacfb0c7abe1679ded3eab792ef91132d6dc3b Mon Sep 17 00:00:00 2001
From: Paul Dreik <github@pauldreik.se>
Date: Tue, 7 Jan 2025 13:57:10 +0100
Subject: [PATCH 4/4] update catch2 in ubuntu CI job

---
 .github/workflows/ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 30ebecf..6522dd7 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -11,7 +11,7 @@ on:
 env:
   osqp_TAG: v0.6.3
   vcpkg_robotology_TAG: v0.0.3
-  Catch2_TAG: v3.0.1
+  Catch2_TAG: v3.8.0
   # Overwrite the VCPKG_INSTALLATION_ROOT env variable defined by GitHub Actions to point to our vcpkg  
   VCPKG_INSTALLATION_ROOT: C:\robotology\vcpkg