Refactor and export AssumeInit trait from rten-tensor and use it downstream
#598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the `AssumeInit` trait used in lazy initialization of collections into its own submodule, expand the documentation and export it for use in downstream crates. In the process the implementation for `Vec<MaybeUninit<T>>` was reworked to be more sound. The previous transmute assumed that `Vec<MaybeUninit<T>>` and `Vec<T>` have the same representation. I believe that is true in practice but not guaranteed. The new implementation de-constructs and then re-constructs the `Vec` in way that I believe should be sound.
This is both more succinct than using a transmute and also more explicit / obvious about what the cast is doing and what the safety requirements are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and export the internal
AssumeInittrait from rten-tensor and use it to replace several[MaybeUninit<T>] -> [T]casts downstream in the rten crate. This makes it more obvious what those casts are doing and what the safety requirements are.