Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🧹 CHORE]: Docs add note about spaces in headers. #1655

Closed
1 task done
gam6itko opened this issue Jul 27, 2023 · 2 comments
Closed
1 task done

[🧹 CHORE]: Docs add note about spaces in headers. #1655

gam6itko opened this issue Jul 27, 2023 · 2 comments
Assignees
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Milestone

Comments

@gam6itko
Copy link
Contributor

No duplicates 🥲.

  • I have searched for a similar issue.

What should be improved or cleaned up?

I faced with problem that allowed_origin does not work correctly if there is a space in the string.

http:
  middleware: [ "headers" ]
  headers:
    cors:
      debug: false
      allowed_origin: "http://localhost:3000, https://some-domain.dev"
      allowed_headers: "Accept, Accept-Language, Authorization, Content-Type"
      allowed_methods: "GET, POST, PUT, PATCH, DELETE"
      exposed_headers: "Cache-Control, Content-Language, Content-Type"
      max_age: 600

Can you please add a note to docs about allowing spaces in allowed_* strings?

@gam6itko gam6itko added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Jul 27, 2023
@gam6itko gam6itko changed the title [🧹 CHORE]: Docs add note about headers. [🧹 CHORE]: Docs add note about spaces in headers. Jul 27, 2023
@rustatian rustatian moved this from Backlog to Todo in General Jul 27, 2023
@github-project-automation github-project-automation bot moved this to Backlog in General Jul 27, 2023
@rustatian rustatian added this to the v2023.2.1 milestone Jul 27, 2023
@rustatian
Copy link
Member

Hey @gam6itko 👋🏻
Thanks for noting that 👍🏻 I'll fix that. No additional docs needed 📖

@rustatian
Copy link
Member

Fixed by: roadrunner-server/headers@e012733

@github-project-automation github-project-automation bot moved this from Todo to Unreleased in General Jul 27, 2023
@rustatian rustatian mentioned this issue Jul 27, 2023
6 tasks
@rustatian rustatian moved this from Unreleased to Done in General Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants